Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI on Windows and macOS #453

Closed
wants to merge 1 commit into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 15, 2022

Follow on from #451 (comment).

Drop support for Python 3.6, end-of-life on 2021-12-23. Moved to #454.

On the CI, test Ubuntu with:

  • Python 2.7 (CPython and PyPy)
  • the lowest and highest 3.x versions
  • Any dev versions

And also test Windows on 3.8 and macOS 3.9.

@boogheta
Copy link
Collaborator

Not sure to understand why coveralls fails
https://github.com/python-twitter-tools/twitter/actions/runs/3058141268/jobs/4935255053

@hugovk
Copy link
Member Author

hugovk commented Sep 15, 2022

I wonder if it's because the action isn't running on macOS and Windows? I added if: matrix.is == 'ubuntu-latest' because it said it was Linux only.

I've split out the 3.6 drop into #454 to see what happens.

@hugovk hugovk changed the title Drop support for EOL Python 3.6 and test CI on Windows and macOS Test CI on Windows and macOS Sep 15, 2022
@hugovk
Copy link
Member Author

hugovk commented Sep 15, 2022

#454 passed.

I've split this PR to add just Windows and macOS and it still fails.

I've reported this upstream to the action to ask for advice: AndreMiras/coveralls-python-action#23

@boogheta
Copy link
Collaborator

I merged 454, and let's wait for their answer before moving on with windows/mac then, thanks!

@hugovk hugovk closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants