Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose bucket #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maurerbot
Copy link

Adding an optional param for the caller to choose an alternative.

Use case example:

  1. Participate user in experiment A.
  2. Receive bucket chosen for experiment A.
  3. Participate user in subsequent experiments B, C, and D in the same bucket as A.
  4. Convert each experiment individually

NOTE: this is a solution to the hash being generated by name+id rather than just id
https://github.com/seatgeek/sixpack/blob/master/sixpack/models.py#L348

@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 78.7% when pulling 0c8511e on VerticodeLabs:choose-bucket into 3a185aa on seatgeek:master.

bump version

update doc
@coveralls
Copy link

Coverage Status

Coverage increased (+0.21%) to 78.7% when pulling 8bff521 on VerticodeLabs:choose-bucket into 3a185aa on seatgeek:master.

@ahmadnassri
Copy link

👍

3 similar comments
@brianirish
Copy link

👍

@hutchic
Copy link

hutchic commented Apr 20, 2015

👍

@hghazal
Copy link

hghazal commented Apr 20, 2015

👍

@kennethklee
Copy link

looks good 👍

@@ -1 +1 @@
__version__ = '2.0.2'
__version__ = '2.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version changes should not be addressed in a PR. See the README in the main repository folder.

@nickveenhof
Copy link
Contributor

I am not sure what the usecase is here. Are you not able to create a new experiment or change the client_id on the implementation side so that it always is unique? I'd love for this patch to see more documentation and its impact.

@maurerbot
Copy link
Author

@nickveenhof I forgot what the use case was now but from what I do remember if you have 1+n tests and you wanted to participate the user in test n based on the bucked chosen from test 1. Another case was to use sixpack to follow a users state conversion.

e.g.

A user can be move to several states (a -> b -> c -> d and a -> b -> c -> a) over time and you want to see if the convert overtime so if they are in state b you participate them in c, d, and a and convert them when the move to those states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants