Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Global.Lute type #23

Closed
etchnight opened this issue Jan 28, 2024 · 2 comments
Closed

Improve Global.Lute type #23

etchnight opened this issue Jan 28, 2024 · 2 comments
Assignees
@Vanessa219
Labels
enhancement New feature or request

Comments

@etchnight
Copy link

原来的标注

export interface Global {
    Lute: Lute ;
}

捕获

似乎应该更改为：

export interface Global {
    Lute: typeof Lute ;
}

捕获2
@Vanessa219
Copy link
Member

已经标明了 static
image

@etchnight
Copy link
Author

这个地方没有问题，我指的是全局上Lute的类型注解，siyuan.d.ts中第68行

360截图18141215235619

export interface Global {
    Lute: Lute ;//应改为 typeof Lute
}

原来的标注似乎是指window.Lute是class Lute的实例，但其并没有实例化

@Vanessa219 Vanessa219 changed the title Global 上的 Lute 类型标注好像有问题 Improve Global.Lute type Jan 29, 2024
@Vanessa219 Vanessa219 self-assigned this Jan 29, 2024
@Vanessa219 Vanessa219 added the enhancement New feature or request label Jan 29, 2024
Vanessa219 added a commit that referenced this issue Jan 29, 2024
@Vanessa219
🎨 fix #23
f140925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vanessa219 @etchnight