Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdocuments created by the database are not displayed in the doc tree #9091

Closed
Tracked by #2829
88250 opened this issue Sep 1, 2023 · 24 comments
Closed
Tracked by #2829

Subdocuments created by the database are not displayed in the doc tree #9091

88250 opened this issue Sep 1, 2023 · 24 comments
Assignees
Milestone

Comments

@88250
Copy link
Member

88250 commented Sep 1, 2023

No description provided.

@88250 88250 added this to the backlog milestone Sep 1, 2023
@88250 88250 mentioned this issue Sep 1, 2023
34 tasks
@mozhux
Copy link

mozhux commented Sep 1, 2023

不显示的前提是他也要能支持点击侧栏打开这样的或者新页签打开,也能在视图里被整个搜索到?

@88250
Copy link
Member Author

88250 commented Sep 1, 2023

@mozhux 是的,在视图里可以打开页签的。

@mozhux
Copy link

mozhux commented Sep 2, 2023

@mozhux 是的,在视图里可以打开页签的。

嗯,我的意思是侧栏打开也支持一下呢,就是那些笔记传统的样子,很多时候还是要对照着看,然后改视图的内容,右侧分屏啥的也行,就是步骤会多。

@88250
Copy link
Member Author

88250 commented Sep 3, 2023

思源没有侧栏这种 UI 元素,打开页签就差不多了,后面看看反馈,实在需要的话加个分屏打开。

@88250 88250 modified the milestones: backlog, 2.10.4 Sep 5, 2023
@88250
Copy link
Member Author

88250 commented Sep 5, 2023

@mozhux 按住 Alt 再点击 打开 就是右分屏打开了

@hackerhui
Copy link

@88250 如果是不在database中的文档,也就是说把文档移入database呢,这种情况又如何展示

@88250
Copy link
Member Author

88250 commented Sep 5, 2023 via email

@88250
Copy link
Member Author

88250 commented Sep 6, 2023

考虑了下,非数据库内移入的情况不隐藏,只有直接在数据库中创建的文档隐藏。

@hackerhui
Copy link

考虑了下,非数据库内移入的情况不隐藏,只有直接在数据库中创建的文档隐藏。

设计成开关吧,是不是会好一些,也不用纠结了

@88250
Copy link
Member Author

88250 commented Sep 6, 2023

加了开关容易导致混乱,还是确定一下规则好。

@88250
Copy link
Member Author

88250 commented Sep 6, 2023

先这样吧,后面看反馈再考虑调整了。

@88250 88250 closed this as completed Sep 6, 2023
@zxhd863943427
Copy link
Contributor

数据库创建的文档要不还是专门放在笔记本根目录下的一个位置?不然文件太多可能会导致展开文档树卡死。

如果直接放在笔记本根目录下的一个位置,就可以在遍历的时候直接跳过了。

@88250
Copy link
Member Author

88250 commented Sep 6, 2023 via email

@zxhd863943427
Copy link
Contributor

有一种做法就是把新建的文档都放到一个路径下,像这样:
图片

数据库创建的文档服从这个设置吗?服从的话就有问题了。

@88250
Copy link
Member Author

88250 commented Sep 6, 2023

不服从,数据库中创建是作为子文档(隐藏的)。

@andyer1511
Copy link

现在有一个问题,把文档树的文档放入数据库后再把数据库删除,文档的数据库属性里会有信息残留。文档数据库属性只能修改,不能删除。如果再新建一个数据库把文档放进去,文档数据库属性栏又会出现第二个数据库的属性。这些无用信息不能删除的话会越积越多。

@88250
Copy link
Member Author

88250 commented Sep 7, 2023

@andyer1511 嗯,这个目前是设计如此,以便在数据库中移出后又添加时能够保留之前的数据(类似 Notion)。移出后属性是否要自动(或者支持手动)隐藏还在考虑,初版暂时就不调整这个设计了,后面继续收集反馈,谢谢。

@zxhd863943427
Copy link
Contributor

@andyer1511 嗯,这个目前是设计如此,以便在数据库中移出后又添加时能够保留之前的数据(类似 Notion)。移出后属性是否要自动(或者支持手动)隐藏还在考虑,初版暂时就不调整这个设计了,后面继续收集反馈,谢谢。

实际情况是移出后重新移入,数据不会保存,而是会覆写。这是bug还是没做相关功能?

@88250
Copy link
Member Author

88250 commented Sep 7, 2023

@zxhd863943427 是 bug,后面修复。

@andyer1511
Copy link

如果只是把文档移出数据库,数据库并没有删除,保留之前的数据,以便复用当然是合理的。
但是直接把原有数据库删除,再新建一个数据库把文档放入,填入的数据和之前完全一致,也是会在文档数据库栏加入一个新的数据库数据的。原有的数据库数据就变多余了,因为原有的数据库已经删除不能再调取出来。我认为这是两个需求。

  • 数据库没删除,文档移出数据库,保留数据,以便复用。
  • 数据库删除后,文档数据库栏允许删除原有数据库信息,以免造成无用数据堆积。

多进行几次数据库删除的操作,文档数据库栏会多出好几个数据库的信息,不管怎么隐藏,这些无用数据还是在的,因此单纯的隐藏并不能满足需求。希望可以在后续的改进版本中,在文档数据库栏下的每个数据库名称旁,加上删除按钮,以便删除多余的数据库信息。

@88250
Copy link
Member Author

88250 commented Sep 7, 2023

@andyer1511 隐藏应该是必要的,删除的话暂时就不考虑了。

@88250
Copy link
Member Author

88250 commented Sep 7, 2023

又考虑了下……

保留属性的话意味着数据肯定是冗余保存的,即使提供删除入口给用户好像也不怎么实用,因为手动删除太繁琐了。虽然保留属性的设计可能会有些用,但是实际上我们已经有数据历史和快照能够恢复文档数据,所以在数据恢复的场景下保留属性的设计意义就不大了。

更改设计为从数据库中移出块时不保留属性。

EightDoor added a commit to EightDoor/siyuan that referenced this issue Sep 7, 2023
* commit '097501c84c56d5a0083a5bd29fc7efe686ee70b9': (82 commits)
  🎨 fix siyuan-note#9123
  🐛 fix siyuan-note#9135
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Update av
  🐛 siyuan-note#9126
  💄
  🐛 The image file name is too long and truncated abnormally Fix siyuan-note#9129
  💄
  🎨 The cloud sync directory name (Bucket) supports up to 63 characters siyuan-note#9130
  🔥 Revert Improve block loading performance on Windows/Linux/macOS amd64 arch Fix siyuan-note#9131
  💄
  📱 fix siyuan-note#9113
  📱 fix siyuan-note#9127
  📱  fix siyuan-note#9111
  📱  fix siyuan-note#9111
  🚨
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  🎨 Update text
  ...
EightDoor added a commit to EightDoor/siyuan that referenced this issue Sep 7, 2023
* develop: (82 commits)
  🎨 fix siyuan-note#9123
  🐛 fix siyuan-note#9135
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Remove av block also remove node attr siyuan-note#9091 (comment)
  🎨 Update av
  🐛 siyuan-note#9126
  💄
  🐛 The image file name is too long and truncated abnormally Fix siyuan-note#9129
  💄
  🎨 The cloud sync directory name (Bucket) supports up to 63 characters siyuan-note#9130
  🔥 Revert Improve block loading performance on Windows/Linux/macOS amd64 arch Fix siyuan-note#9131
  💄
  📱 fix siyuan-note#9113
  📱 fix siyuan-note#9127
  📱  fix siyuan-note#9111
  📱  fix siyuan-note#9111
  🚨
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  🎨 Update text
  ...
@zxhd863943427
Copy link
Contributor

custom-avs似乎没有移除。

@88250
Copy link
Member Author

88250 commented Sep 25, 2023

custom-avs似乎没有移除。

感谢反馈,稍后改进。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants