Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid requests during boot #10227

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

Reverier-Xu
Copy link
Contributor

@Reverier-Xu Reverier-Xu commented Jan 22, 2024

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

上文: 思源笔记前端启动时会对 80 端口发送 /api/system/bootProgress 请求

我发现在kernel启动过程中app/electron/boot.html 就是作为占位页面存在的,在kernel启动之后就会被替换成 */appearance/boot/index.html。所以在 boot.html 中获取的 location.port 是空值,会导致前端一直请求 80 端口,移除这个页面的循环请求不会影响启动进程的显示。

@88250 88250 assigned 88250 and Reverier-Xu and unassigned 88250 Jan 23, 2024
@88250 88250 added this to the 2.12.4 milestone Jan 23, 2024
@88250 88250 changed the title 🐛 remove invalid requests during boot Remove invalid requests during boot Jan 23, 2024
@88250 88250 added Bug and removed Enhancement labels Jan 23, 2024
@88250 88250 merged commit beefd87 into siyuan-note:dev Jan 23, 2024
3 checks passed
EightDoor added a commit to EightDoor/siyuan that referenced this pull request Jan 24, 2024
* commit '0f91f51bb0f8fc7f71e3c038ae45a3d69d3e95e1': (109 commits)
  🐛 fix siyuan-note#10238
  🎨 Update linux/macOS packing font
  🎨 Update npm mirror
  🔖 Release v2.12.4
  🚨
  🎨 菜单右键复制无效
  🎨 fix siyuan-note#10230
  🎨 fix siyuan-note#10230
  📝 Update changelogs
  🐛 remove invalid requests during boot (siyuan-note#10227)
  📝 Update changelogs
  🎨 Improve search and replace spaces siyuan-note#10231
  📝 Update changelogs
  🎨 Improve data sync to prevent an old snapshot to overwrite the new one siyuan-note#10229
  🎨 fix siyuan-note#10225
  🎨 Update README
  📝
  ♻️
  🐛 Data sync may cause data loss on Android 14 siyuan-note#10205
  🐛 Data sync may cause data loss on Android 14 siyuan-note#10205
  ...

# Conflicts:
#	README.md
#	app/src/config/account.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants