Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

为桌面端窗口标题栏添加应用图标 #7032

Merged
merged 3 commits into from Jan 12, 2023
Merged

为桌面端窗口标题栏添加应用图标 #7032

merged 3 commits into from Jan 12, 2023

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

@Zuoqiu-Yingyi Zuoqiu-Yingyi commented Jan 11, 2023 •
edited

  • Please commit to the dev branch 请提交到 dev 开发分支

image

@88250 88250 requested a review from Vanessa219 January 11, 2023 12:29
@88250 88250 added this to the 2.7.0 milestone Jan 11, 2023
@Vanessa219 Vanessa219 merged commit 88fd082 into siyuan-note:dev Jan 12, 2023
@88250
Copy link
Member

88250 commented Jan 12, 2023

左击好像没有反应？

@88250
Copy link
Member

88250 commented Jan 12, 2023

另外图标的颜色不大对劲，感觉用纯白底比较好。

image

@88250
Copy link
Member

88250 commented Jan 12, 2023

@Zuoqiu-Yingyi

@Zuoqiu-Yingyi
Copy link
Contributor Author

左击好像没有反应？

右键才能弹出系统窗口菜单

另外图标的颜色不大对劲，感觉用纯白底比较好。

没有在图标库中找到这个😂

@Zuoqiu-Yingyi Zuoqiu-Yingyi deleted the dev-window-app-icon branch January 12, 2023 10:20
@88250
Copy link
Member

88250 commented Jan 12, 2023

能不能实现左击也弹出？

@Zuoqiu-Yingyi
Copy link
Contributor Author

能不能实现左击也弹出？

目前没找到其他 electron 应用实现了该功能

@88250
Copy link
Member

88250 commented Jan 12, 2023

那先这样吧，等有空再研究。

@88250 88250 mentioned this pull request Jan 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@Zuoqiu-Yingyi Zuoqiu-Yingyi

Labels
Enhancement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zuoqiu-Yingyi @88250 @Vanessa219