Message Delivery #53
Open
Message Delivery #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Deliver" button is replaced with text while waiting for delivery
Currently only supports SMTP. Configuration is provided at the command line. Default values are setup for GMail delivery.
|
This is in response to #4 |
|
Great idea, not sure how comfortable I am with the gmail integration. I'd be more inclined to just act like a first-class SMTP server, however that raises problems via ISPs. Also want the deliveree's address to be changeable in the web interface. |
|
The current setup can take in any SMTP configuration. I chose to add GMail as the default SMTP configuration figuring it was relatively common and easiest to setup. For the deliveree's address, what use case do you have in mind for wanting to change their address via the interface? |
|
+1, great idea. |
sj26
force-pushed
the
master
branch
2 times, most recently
from
aa7bc8e
to
23398d7
Compare
|
It would be great to have this merged. |
|
Great idea. When will it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a "Deliver" button to the web interface next to the "Download" button.
In the backend, there is now a DeliveryService class that is initialized with a message hash and responds to #deliver!. The current implementation uses a basic Net::SMTP setup for delivery. SMTP options are provided on the command line with defaults setup for GMail. So if you are using GMail, the minimum necessary configuration is:
mailcatcher --delivery-user-name YOURADDRESS@gmail.com --delivery-password YOURPASS
There is also a '--delivery-recipient' option which overwrites the recipient field on all delivered messages. This allows you to specify an email address that you would like all messages to be delivered to.