Merge pull request #49 from sjaensch/reenable-connection-error-tests-…

…on-win32 Re-enable connection error integration tests on Windows
sjaensch · Oct 27, 2020 · d6d99d6 · d6d99d6
2 parents b39c22e + d69cd23
commit d6d99d6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/bravado_asyncio/response_adapter.py b/bravado_asyncio/response_adapter.py
@@ -46,7 +46,7 @@ def reason(self) -> str:
         )  # aiohttp 3.4.0 doesn't annotate this attribute correctly
 
     @property
-    def headers(self) -> CIMultiDictProxy[str]:
+    def headers(self) -> CIMultiDictProxy:
         return self._delegate.headers
 
     def json(self, **_: Any) -> Dict[str, Any]:

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,7 +1,7 @@
 aiohttp
 bottle
 bravado-core>=4.11.0
-bravado[integration-tests,fido]>=11.0.1
+bravado[integration-tests,fido]>=11.0.2
 coverage
 ephemeral_port_reserve
 mock<4

diff --git a/tests/integration/bravado_integration_test.py b/tests/integration/bravado_integration_test.py
@@ -1,5 +1,3 @@
-import sys
-
 import aiohttp.client_exceptions
 import pytest
 from bravado.testing.integration_test import IntegrationTestsBaseClass
@@ -38,27 +36,3 @@ def test_request_timeout_errors_are_thrown_as_BravadoTimeoutError(
         self, swagger_http_server
     ):  # pragma: no cover
         pass
-
-    @pytest.mark.skipif(
-        sys.platform == "win32",
-        reason="Test does not throw correct exception type on Windows",
-    )
-    def test_connection_errors_are_thrown_as_BravadoConnectionError(
-        self, not_answering_http_server
-    ):  # pragma: no cover
-        return super().test_connection_errors_are_thrown_as_BravadoConnectionError(
-            not_answering_http_server
-        )
-
-    @pytest.mark.skipif(
-        sys.platform == "win32",
-        reason="Test does not throw correct exception type on Windows",
-    )
-    def test_swagger_client_connection_errors_are_thrown_as_BravadoConnectionError(
-        self, not_answering_http_server, swagger_client, result_getter,
-    ):  # pragma: no cover
-        return super().test_swagger_client_connection_errors_are_thrown_as_BravadoConnectionError(
-            not_answering_http_server=not_answering_http_server,
-            swagger_client=swagger_client,
-            result_getter=result_getter,
-        )