Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional aiohttp dependency #14

Conversation

macisamuele
Copy link
Collaborator

The goal of this PR is to make setup.py more wheel friendly (context on #13).

In case of python<3.5.3 extra_requires will ensure that aiohttp is bounded to aiohttp<3.0.
To guarantee that this approach will be effective for "old" python versions I've added a new travis task that uses python 3.5.2

NOTE: internally, this approach is already in use (ie. bravado_decorators)

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling fe39301 on macisamuele:maci-update-conditional-aiohttp-dependency into ec73096 on sjaensch:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fe39301 on macisamuele:maci-update-conditional-aiohttp-dependency into ec73096 on sjaensch:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fe39301 on macisamuele:maci-update-conditional-aiohttp-dependency into ec73096 on sjaensch:master.

Copy link
Owner

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had issues internally with pip not installing the right version of aiohttp if bravado-asyncio was installed as a dependency of aiobravado, let's see if this way of specifying it fixes it. Otherwise we'll need to try a different approach.

@sjaensch sjaensch merged commit b9c36b0 into sjaensch:master Mar 8, 2018
@macisamuele macisamuele deleted the maci-update-conditional-aiohttp-dependency branch June 14, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants