Rework tox.ini so that we specify Python versions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea behind the tox.ini design was to allow users to use any Python 3 version that's compatible with bravado-asyncio (e.g. Python 3.5, 3.6, in-development 3.7). Unfortunately we're running into problems executing tests internally on machines where the default Python 3 version is 3.4. So I'm reworking tox.ini to explicitly specify the Python versions we support. Developers will be required to have a working Python 3.6 installation.
I'm also updating pre-commit hooks, fixing an issue that prevented them from fully working outside of Yelp, and running them as part of our travis build.