Second pass of clang-tidy warnings fixes

sjanel · Jun 15, 2024 · 7033e0a · 7033e0a
1 parent 7728734
commit 7033e0a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/.clang-tidy-ignore b/.clang-tidy-ignore
@@ -1,6 +1,6 @@
 **/json.hpp
 
 # Ignore all protobuf/gRPC generated source files
-*.pb.cc
+**/*.pb.cc
 
 */_deps/*
diff --git a/src/engine/src/exchangesorchestrator.cpp b/src/engine/src/exchangesorchestrator.cpp
@@ -744,7 +744,8 @@ TradeResultPerExchange ExchangesOrchestrator::smartSell(MonetaryAmount startAmou
   MonetaryAmount remStartAmount = startAmount;
   if (!exchangeAmountPairVector.empty()) {
     // Sort exchanges from largest to lowest available amount
-    std::ranges::stable_sort(exchangeAmountPairVector, std::greater{}, [](const auto &p) { return p.second; });
+    std::ranges::stable_sort(exchangeAmountPairVector, std::greater{},
+                             [](const auto &exchangeAmount) { return exchangeAmount.second; });
 
     ExchangeRetriever::PublicExchangesVec publicExchanges =
         SelectUniquePublicExchanges(_exchangeRetriever, exchangeAmountPairVector, false);  // unsorted

diff --git a/src/engine/test/exchangesorchestrator_private_test.cpp b/src/engine/test/exchangesorchestrator_private_test.cpp
@@ -209,16 +209,16 @@ TEST_F(ExchangeOrchestratorTest, WithdrawImpossibleTo) {
   EXPECT_FALSE(deliveredWithdrawInfo.hasBeenInitiated());
 }
 
-inline bool operator==(const DeliveredWithdrawInfo &lhs, const DeliveredWithdrawInfo &rhs) {
+static inline bool operator==(const DeliveredWithdrawInfo &lhs, const DeliveredWithdrawInfo &rhs) {
   return lhs.withdrawId() == rhs.withdrawId();
 }
 
 namespace api {
-inline bool operator==(const InitiatedWithdrawInfo &lhs, const InitiatedWithdrawInfo &rhs) {
+static inline bool operator==(const InitiatedWithdrawInfo &lhs, const InitiatedWithdrawInfo &rhs) {
   return lhs.withdrawId() == rhs.withdrawId();
 }
 
-inline bool operator==(const SentWithdrawInfo &lhs, const SentWithdrawInfo &rhs) {
+static inline bool operator==(const SentWithdrawInfo &lhs, const SentWithdrawInfo &rhs) {
   return lhs.withdrawStatus() == rhs.withdrawStatus() && lhs.netEmittedAmount() == rhs.netEmittedAmount();
 }
 }  // namespace api

diff --git a/src/objects/test/marketorderbook_test.cpp b/src/objects/test/marketorderbook_test.cpp
@@ -31,9 +31,10 @@ MarketOrderBookLines CreateMarketOrderBookLines(std::initializer_list<OrderBookL
 
   return marketOrderBookLines;
 }
+
 }  // namespace
 
-constexpr bool operator==(const AmountPrice &lhs, const AmountPrice &rhs) {
+static constexpr bool operator==(const AmountPrice &lhs, const AmountPrice &rhs) {
   return lhs.amount == rhs.amount && lhs.price == rhs.price;
 }
 

diff --git a/src/serialization/test/proto-market-order-book-converter_test.cpp b/src/serialization/test/proto-market-order-book-converter_test.cpp
@@ -32,9 +32,6 @@ MarketOrderBookLines CreateMarketOrderBookLines(std::initializer_list<OrderBookL
   return marketOrderBookLines;
 }
 
-constexpr bool operator==(const AmountPrice &lhs, const AmountPrice &rhs) {
-  return lhs.amount == rhs.amount && lhs.price == rhs.price;
-}
 }  // namespace
 
 class ProtoMarketOrderBookTest : public ::testing::Test {