Use range instead of iterators for parallelTransform in thread pool, …

…fix clang-tidy warnings

.clang-tidy-ignore

@@ -1,3 +1,6 @@
 **/json.hpp
 
+# Ignore all protobuf/gRPC generated source files
+*.pb.cc
+
 */_deps/*

src/api-objects/include/exchangeprivateapitypes.hpp

@@ -9,6 +9,7 @@
 #include "withdraw.hpp"
 
 namespace cct {
+
 using Deposits = vector<Deposit>;
 using DepositsSet = FlatSet<Deposit>;
 
@@ -27,4 +28,5 @@ struct TradedAmountsVectorWithFinalAmount {
   TradedAmountsVector tradedAmountsVector;
   MonetaryAmount finalAmount;
 };
+
 }  // namespace cct

src/api-objects/test/recentdeposit_test.cpp

@@ -9,10 +9,6 @@
 
 namespace cct::api {
 
-inline bool operator==(const RecentDeposit &lhs, const RecentDeposit &rhs) {
-  return lhs.amount() == rhs.amount() && lhs.timePoint() == rhs.timePoint();
-}
-
 class RecentDepositTest : public ::testing::Test {
  protected:
   void expectNotFound(MonetaryAmount ma) {

src/api/common/test/exchangeprivateapi_test.cpp

@@ -46,31 +46,32 @@
 #include "withdrawordeposit.hpp"
 
 namespace cct {
-inline bool operator==(const DeliveredWithdrawInfo &lhs, const DeliveredWithdrawInfo &rhs) {
-  return lhs.withdrawId() == rhs.withdrawId();
-}
 
-inline BalancePortfolio operator+(const BalancePortfolio &balancePortfolio, const TradedAmounts &tradedAmounts) {
+static inline BalancePortfolio operator+(const BalancePortfolio &balancePortfolio, const TradedAmounts &tradedAmounts) {
   BalancePortfolio ret = balancePortfolio;
   ret += tradedAmounts.to;
   ret += -tradedAmounts.from;
   return ret;
 }
 
-inline bool operator==(const TradedAmountsVectorWithFinalAmount &lhs, const TradedAmountsVectorWithFinalAmount &rhs) {
+static inline bool operator==(const TradedAmountsVectorWithFinalAmount &lhs,
+                              const TradedAmountsVectorWithFinalAmount &rhs) {
   return lhs.finalAmount == rhs.finalAmount && lhs.tradedAmountsVector == rhs.tradedAmountsVector;
 }
 
+static inline bool operator==(const DeliveredWithdrawInfo &lhs, const DeliveredWithdrawInfo &rhs) {
+  return lhs.withdrawId() == rhs.withdrawId();
+}
 }  // namespace cct
 
 namespace cct::api {
 
-inline bool operator==(const TradeContext &lhs, const TradeContext &rhs) {
+static inline bool operator==(const TradeContext &lhs, const TradeContext &rhs) {
   // We don't compare on value userRef which is set from a timestamp
   return lhs.mk == rhs.mk && lhs.side == rhs.side;
 }
 
-inline bool operator==(const TradeInfo &lhs, const TradeInfo &rhs) {
+static inline bool operator==(const TradeInfo &lhs, const TradeInfo &rhs) {
   return lhs.tradeContext == rhs.tradeContext && lhs.options == rhs.options;
 }
 
@@ -442,11 +443,11 @@ TEST_F(ExchangePrivateTest, MakerTradeQuoteToBaseTimeout) {
   EXPECT_EQ(exchangePrivate.trade(from, market.base(), tradeOptions), partialMatchedTradedAmounts);
 }
 
-inline bool operator==(const InitiatedWithdrawInfo &lhs, const InitiatedWithdrawInfo &rhs) {
+static inline bool operator==(const InitiatedWithdrawInfo &lhs, const InitiatedWithdrawInfo &rhs) {
   return lhs.withdrawId() == rhs.withdrawId();
 }
 
-inline bool operator==(const SentWithdrawInfo &lhs, const SentWithdrawInfo &rhs) {
+static inline bool operator==(const SentWithdrawInfo &lhs, const SentWithdrawInfo &rhs) {
   return lhs.withdrawStatus() == rhs.withdrawStatus() && lhs.netEmittedAmount() == rhs.netEmittedAmount();
 }
 

src/api/exchanges/src/binancepublicapi.cpp

@@ -26,7 +26,6 @@
 #include "curlpostdata.hpp"
 #include "currencycode.hpp"
 #include "currencycodeset.hpp"
-#include "currencyexchange.hpp"
 #include "currencyexchangeflatset.hpp"
 #include "exchangepublicapi.hpp"
 #include "exchangepublicapitypes.hpp"

src/api/exchanges/src/bithumbprivateapi.cpp

@@ -42,7 +42,6 @@
 #include "exchangepublicapitypes.hpp"
 #include "file.hpp"
 #include "httprequesttype.hpp"
-#include "ipow.hpp"
 #include "market.hpp"
 #include "monetaryamount.hpp"
 #include "ndigits.hpp"

src/api/exchanges/src/bithumbpublicapi.cpp

@@ -4,10 +4,10 @@
 #include <chrono>
 #include <cstdint>
 #include <ctime>
+#include <iomanip>
 #include <iterator>
 #include <memory>
 #include <optional>
-#include <ranges>
 #include <sstream>
 #include <string>
 #include <string_view>

src/engine/src/coincenter.cpp

@@ -63,10 +63,10 @@ void FillConversionTransferableCommandResults(const MonetaryAmountPerExchange &m
   }
 }
 
-}  // namespace
-
 volatile sig_atomic_t g_signalStatus = 0;
 
+}  // namespace
+
 // According to the standard, 'SignalHandler' function should have C linkage:
 // https://en.cppreference.com/w/cpp/utility/program/signal
 // Thus it's not possible to use a lambda and pass some

src/engine/src/coincentercommand.cpp

@@ -12,7 +12,6 @@
 #include "monetaryamount.hpp"
 #include "ordersconstraints.hpp"
 #include "replay-options.hpp"
-#include "timedef.hpp"
 #include "tradeoptions.hpp"
 #include "withdrawoptions.hpp"
 #include "withdrawsconstraints.hpp"