Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not silently continue for currency longer than 7 characters #329

Closed
sjanel opened this issue Oct 13, 2022 · 0 comments · Fixed by #331
Closed

Do not silently continue for currency longer than 7 characters #329

sjanel opened this issue Oct 13, 2022 · 0 comments · Fixed by #331
Labels
bug Something isn't working

Comments

@sjanel
Copy link
Owner

sjanel commented Oct 13, 2022

When user provides a currency code of more than 7 characters, coincenter truncates it and continue the process with the truncated currency code. This behavior is not intuitive and we could simply reject commands with too long currency codes.
@sjanel sjanel added the bug Something isn't working label Oct 13, 2022
@sjanel sjanel linked a pull request Oct 24, 2022 that will close this issue
Increase maximum number of characters of currency code to 10 #331
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase maximum number of characters of currency code to 10 sjanel/coincenter
1 participant
@sjanel