Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum number of characters of currency code to 10 #331

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

sjanel
Copy link
Owner

@sjanel sjanel commented Oct 24, 2022

  • Increase maximum length of a currency code from 7 to 10
  • Throw invalid argument if MonetaryAmount is built with a CurrencyCode too long, and in CLI as well

@sjanel sjanel added the enhancement New feature or request label Oct 24, 2022
@sjanel sjanel force-pushed the feature/larger-currency-codes branch 2 times, most recently from be92d2d to 784127f Compare October 24, 2022 21:32
@sjanel sjanel linked an issue Oct 24, 2022 that may be closed by this pull request
@sjanel sjanel force-pushed the feature/larger-currency-codes branch from 784127f to f5e1135 Compare October 25, 2022 07:10
…nvalid argument if MonetaryAmount is built with a CurrencyCode too long, and in CLI as well
@sjanel sjanel force-pushed the feature/larger-currency-codes branch from f5e1135 to 82f30a7 Compare October 26, 2022 22:39
@sjanel sjanel merged commit 97806c5 into main Oct 27, 2022
@sjanel sjanel deleted the feature/larger-currency-codes branch October 27, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not silently continue for currency longer than 7 characters
1 participant