Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception formatting with all changes #334

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Exception formatting with all changes #334

merged 1 commit into from
Oct 31, 2022

Conversation

sjanel
Copy link
Owner

@sjanel sjanel commented Oct 28, 2022 •
edited

  • Format Wallet, exception, ExchangeName
  • Wrapper of std::format when available in cct_format.hpp

@sjanel sjanel added the refactoring Code cleaning and refactoring label Oct 28, 2022
@sjanel sjanel force-pushed the feature/exception-exchange-name-format branch 7 times, most recently from bf77ce8 to 7fbc591 Compare October 29, 2022 18:22
@sjanel sjanel changed the title Addition of formatting to simplify code for ExchangeName and exception Exception formatting Oct 29, 2022
@sjanel sjanel marked this pull request as draft October 29, 2022 19:17
@sjanel
Copy link
Owner Author

sjanel commented Oct 29, 2022

Windows build is failing - looks like a MSVC bug. Trying to isolate the issue...

@sjanel sjanel changed the title Exception formatting Exception formatting with all changes Oct 29, 2022
@sjanel sjanel force-pushed the feature/exception-exchange-name-format branch from 7fbc591 to 66c7462 Compare October 29, 2022 21:49
@sjanel sjanel force-pushed the feature/exception-exchange-name-format branch from 66c7462 to a55998f Compare October 31, 2022 09:09
@sjanel sjanel marked this pull request as ready for review October 31, 2022 09:19
@sjanel sjanel merged commit f4e3e1a into main Oct 31, 2022
@sjanel sjanel deleted the feature/exception-exchange-name-format branch October 31, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Code cleaning and refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sjanel