Support for Dvorak and alternative keyboard layouts in LustyJuggler #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the key labels were hard-coded to the buffers displayed by NameBar. Now NameBar requires these labels on initialization, passed in as an array. This allows for NameBar greater flexibility and to correctly display the correct alphabetic keys for other keyboard layouts, such as Dvorak.
The LustyJuggler class in juggler.rb required refactoring to make it
possible to subclass the class for the purpose of allowing alternative
layouts. A central challenge was the reliance on a class variable
("@@keys"). Class variables can not be overridden for only subclasses;
setting "@@keys" to a different value in any subclass caused the mapping
to change also for the LustyJuggler parent class. See the following
webpages for further explanation on the complications of inheritance
with class variables
* http://rubysource.com/class-variables-a-ruby-gotcha/
* http://sporkmonger.com/2007/2/19/instance-variables-class-variables-and-inheritance-in-ruby
* http://ghouston.blogspot.com/2006/06/ruby-class-variables-attributes-and.html
This necessitated moving the variable to an instance variable, where it
is still private, but can be overridden easily by subclasses.
Further refactoring involved breaking apart the "@@keys" variable into
alphabetic and numeric components, and storing the cancels keys in an
instance variable, too, then looping through these data structures to
map and unmap keys, rather than have a dozen hard-coded mappings and
unmappings.
Overall the result is a LustyJuggler class that can be subclassed
somewhat easily to change the mappings.
Remaps the alphabetic keys for LustyJuggler navigation to match the home
row keys for the Dvorak layout. This takes place by subclassing the
"LustyJuggler" class in juggler.rb, given as LustyJugglerDvorak.
The user can designate the desire to use the Dvorak layout for
LustyJuggler by placing the following line in his/her .vimrc:
let g:LustyJugglerKeyboardLayout = "dvorak"
LustyJuggler will read this configuration variable and set the mapping
to Dvorak if the variable exists and is set to "dvorak".
Closed
|
Merged - thanks! |
|
p.s. Excellent patch. |
|
Thanks so much! =-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added fairly robust support for the Dvorak keyboard layout to LustyJuggler by refactoring the LustyJuggler and NameBar Ruby classes. In particular, the refactoring of the LustyJuggler class makes it extensible by subclassing, which was difficult previously due to use of class variables (which are affected in parent classes upon reassignment by subclasses) and hard-coding of mapping and unmappings.
This series of commits will add support for Dvorak and lays the way for further extension of other keyboard layouts through subclassing the LustyJuggler class.