Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Use "quit" statement as an alternative to Ctrl+D #273

Closed
lvcabral opened this issue Jul 25, 2019 · 0 comments · Fixed by #290
Closed

Suggestion: Use "quit" statement as an alternative to Ctrl+D #273

lvcabral opened this issue Jul 25, 2019 · 0 comments · Fixed by #290
Labels
cli Affects the command-line interface to `brs` enhancement Any addition to this project's existing capabilities
Projects
Issue Triage

Comments

@lvcabral
Copy link
Contributor

Roku supports the quit statement during a telnet debug session to close the channel and debug session. I think this would be nice to have in brs command line interface.
@sjbarag sjbarag added this to Low priority in Issue Triage Jul 25, 2019
@sjbarag sjbarag added cli Affects the command-line interface to `brs` enhancement Any addition to this project's existing capabilities labels Jul 25, 2019
lvcabral referenced this issue in lvcabral/brs-engine Aug 20, 2019
Added "quit" and "exit" as alternatives to exit brs repl, also fixed …
07c772f 
…the "invalid" message after every command #272 #273
@lvcabral lvcabral mentioned this issue Sep 20, 2019
Merged
Issue Triage automation moved this from Low priority to Closed Sep 23, 2019
sjbarag pushed a commit that referenced this issue Sep 23, 2019
@lvcabral @sjbarag
feat(cli): Exit via "quit"/"exit", and remove spurious "invalid" mess…
9d46c13 
…ages (#290)

fixes #272 
fixes #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Affects the command-line interface to `brs` enhancement Any addition to this project's existing capabilities
Projects
Issue Triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added "quit" and "exit" cli statements and fixed "invalid" message #272 #273 lvcabral/brs-engine
2 participants
@sjbarag @lvcabral