Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parse,e2e): Allow 'function' as an argument type #185

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix(parse,e2e): Allow 'function' as an argument type #185

merged 1 commit into from
Mar 1, 2019

Conversation

sjbarag
Copy link
Owner

@sjbarag sjbarag commented Mar 1, 2019

I'd accidentally allowed "as callable" (the internal name for a BrightScript function) insntead of "as function".

fixes #177

@sjbarag
fix(parse,e2e): Allow 'function' as an argument type
33a7087 
I'd accidentally allowed "as callable" (the internal name for a
BrightScript function) insntead of "as function".

fixes #177
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) parser Affects this project's token parser labels Mar 1, 2019
@sjbarag sjbarag merged commit e9c7701 into master Mar 1, 2019
@sjbarag sjbarag deleted the function-as-param-type branch March 1, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) parser Affects this project's token parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function should be allowed as type
1 participant
@sjbarag