Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lex,parse,interp,e2e): Implement global LINE_NUM variable #242

Merged
merged 9 commits into from
May 23, 2019
Merged

feat(lex,parse,interp,e2e): Implement global LINE_NUM variable #242

merged 9 commits into from
May 23, 2019

Conversation

sjbarag
Copy link
Owner

@sjbarag sjbarag commented May 23, 2019

The LINE_NUM global variable is always equal to the current source file's line number. Now it's available at runtime and doesn't cause parse failures either!

fixes #232

@sjbarag
chore(parse): Convert disallowedIdentifiers to a Set
194d385 
We only ever use it for inclusion checking, so no need to iterate across
the entire thing every time!
@sjbarag
fix(lex,parse): Parse LINE_NUM variable as a regular identifier
5adef73 
It's not a keyword but is _definitely_ reserved!
@sjbarag
feat(env): Resolve "LINE_NUM" variable specially
77d338d
@sjbarag
chore(err,interp): Prevent spurious "implementation error" reports
8a4a71a 
The JavaScript inheritance chain will work well enough for us in this
case, so no need to add a `.kind` property to custom errors!
@sjbarag
test(interp): Fix FunctionDeclaration tests
b62f809 
I wasn't providing the correct type for the tokens object! :(
@sjbarag
test(interp): Fix more tests
afeb263
@sjbarag
test(lexer): Ensure lexer emits identifier for LINE_NUM
4b33762
@sjbarag
test(env): Ensure Environment returns line number for LINE_NUM variable
e15ca3d 
Implementing this check in the environment itself feels not-unreasonable
at worst, and like the correct place at best.
@sjbarag
test(e2e): Test LINE_NUM support end-to-end
f221316 
It works, woo!
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior enhancement Any addition to this project's existing capabilities lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser interpreter Affects this project's tree-walking interpreter e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) labels May 23, 2019
@sjbarag sjbarag merged commit 4caa4a2 into master May 23, 2019
@sjbarag sjbarag deleted the add-global-line_num-variable branch May 23, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) enhancement Any addition to this project's existing capabilities interpreter Affects this project's tree-walking interpreter lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of LINE_NUM variable causes a parse failure
1 participant
@sjbarag