Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop statement syntax support #247

Merged
merged 2 commits into from
May 29, 2019
Merged

Stop statement syntax support #247

merged 2 commits into from
May 29, 2019

Conversation

TwitchBronBron
Copy link
Contributor

Fixes #192

@sjbarag sjbarag mentioned this pull request May 29, 2019
Merged
sjbarag
sjbarag approved these changes May 29, 2019
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid! Thanks for the fix 😄

src/parser/Statement.ts
}

get location() {
return {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could have gotten away with return this.tokens.stop.location but 🤷‍♂

@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser labels May 29, 2019
@sjbarag sjbarag merged commit 3a6f30b into sjbarag:master May 29, 2019
@TwitchBronBron TwitchBronBron deleted the stop-statement branch May 30, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjbarag sjbarag sjbarag approved these changes

Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior lexer Affects this project's lexer (aka scanner) parser Affects this project's token parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop keyword causes parse errors
2 participants
@TwitchBronBron @sjbarag