fix(manifest): BREAKING-CHANGE Prevent precision loss in parsed manifest #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numbers are allowed in RBI's `manifest` file, but `brs` used to lose precision by parsing them as numbers. This caused some subtle differences when a `manifest` was re-serialized after parsing, in which `1.0` was represented only as `1`. It's unclear whether or not this caused issues with applications run in RBI using that rewritten `manifest`, but this was originally reported back in July 2019. Stop parsing `manifest` values as numbers to prevent precision loss. fixes #279
sjbarag
added
bug
sjbarag
requested review from
strattonbrazil,
alimnios72,
lkipke and
kirkyoder
alimnios72
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers are allowed in RBI's
manifestfile, butbrsused to lose precision by parsing them as numbers. This caused some subtle differences when amanifestwas re-serialized after parsing, in which1.0was represented only as1. It's unclear whether or not this caused issues with applications run in RBI using that rewrittenmanifest, but this was originally reported back in July 2019. Stop parsingmanifestvalues as numbers to prevent precision loss.fixes #279