Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle policy support for the createRepository task. #34

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

wwbakker
Copy link

Repositories can have a lifecycle policy to automatically clean old images from the ECR repository.
This feature allows you to set the lifecycle policy in the same way you could add the ECR access policy.

I tested it and the lifecycle policy is correctly added to AWS, when using the steps in the readme.

Copy link
Owner

@sjednac sjednac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @wwbakker!

@@ -14,7 +14,7 @@ An [SBT](http://www.scala-sbt.org/) plugin for managing [Docker](http://docker.i

Add the following to your `project/plugins.sbt` file:

addSbtPlugin("com.mintbeans" % "sbt-ecr" % "0.13.0")
addSbtPlugin("com.mintbeans" % "sbt-ecr" % "0.14.0")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule, please don't change this as it's an integral part of the release process (i.e. should be updated only after the current version is published to Bintray).

That being said, we can leave this in for now, as I'm going to release in a moment anyway.

@sjednac sjednac merged commit 318e51b into sjednac:master Nov 29, 2018
@sjednac
Copy link
Owner

sjednac commented Nov 29, 2018

Published under 0.14.0. I just tested it locally - works like a charm!

Thanks again for this incredibly useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants