Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking side bar menu item does not automatically collapse the side bar. #34

Closed
alanmachadouk opened this issue Nov 24, 2020 · 1 comment
Closed

Clicking side bar menu item does not automatically collapse the side bar. #34

alanmachadouk opened this issue Nov 24, 2020 · 1 comment
Assignees
@sjefvanleeuwen
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alanmachadouk
Copy link

Great job in the conversion, just testing and found this annoying difference.

When the side bar is in a collapsed state.

image

Clicking SideBarMenuItem menu item does not automatically collapse.
It is left for the user to move move away from side bar before the collapse occurs.

image

This is different behavior to AdminLTE.
@sjefvanleeuwen
Copy link
Owner

sjefvanleeuwen commented Dec 2, 2020 •
edited

Confirmed

@sjefvanleeuwen sjefvanleeuwen added enhancement New feature or request good first issue Good for newcomers labels Dec 2, 2020
@sjefvanleeuwen sjefvanleeuwen self-assigned this Dec 2, 2020
@alanmachadouk alanmachadouk mentioned this issue Dec 3, 2020
Closed
sjefvanleeuwen added a commit that referenced this issue Dec 9, 2020
@sjefvanleeuwen
Automatically collapse the side bar on click. #34
840fe7d
sjefvanleeuwen added a commit that referenced this issue Dec 9, 2020
@sjefvanleeuwen
Fix: Small side effect for #34
f1bad28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjefvanleeuwen sjefvanleeuwen

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanmachadouk @sjefvanleeuwen