Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/user authentication #11

Merged
merged 13 commits into from
Nov 13, 2019
Merged

Feature/user authentication #11

merged 13 commits into from
Nov 13, 2019

Conversation

sjeguedes
Copy link
Owner

@sjeguedes sjeguedes commented Nov 13, 2019

This branch creates authentication forms process (login, password renewal request and reset pages).
This merge aims at testing better workflow with development and features branches added to master. No issue is referenced for this pull request.

This branch treated expected changes and "fixed" issue: #7

  • Added login (with remember me functionality) and logout action (with event handler)

  • Added authentication checker to verify account activation and control login access

  • Started first unit tests on User entity

  • Added password renewal request (unique access with personal link provided by email) and authorization

  • Added password renewal (with confirmation by email)

  • Refactored actions (controllers) scripts by using form handlers, email configuration to pass to mailer, custom event, interfaces and factories

These pages need to be completed with User registration and account validation process.
Entities constructors improvements are also necessary.

Message: please accept this merge and be conscious multiple changes will be made later.

…ted cascade and orphanRemoval Doctrine annotation attributes to decide later what to do during actions for persist, remove, etc
…. Fixed other entities to strenghten assertion for updateDate in constructor
…face on UserRepository. Checked HTTP basic authentication to validate security configuration. Improved other entities. Unit testing needs to be enlarged for passed and future functionalities to improve project stability
…ed remember me functionality with cookie lifetime in framework.yaml - fixed main role label on header user profile
…nal access to form with user id and token and renewal confirmation. Need to continue refactoring by modifying services to make actions lighter - entity service layer UserManager and form handlers.
…ch as creating form handlers to manage request for each form
…with ParameterBagInterface for dependency injection in service classes. Improved custom form errors in Twig templates.
…lers to manage validations (constraints and custom validation) and call final actions (user update, email sending...), email configuration to feed the mailer and custom event instances created with factories.
@sjeguedes sjeguedes merged commit 916b9b8 into develop Nov 13, 2019
@sjeguedes
Copy link
Owner Author

Merge accepted with comments:

Check untracked files more regularly.

Pull "develop" origin branch on local branch to synchronise local and remote repositories.

Don't forget to rebase "master" branch with commits created on "develop" branch when being on local repository.

Then create a tag for rebase operation.

Push "master" branch and tag on remote repository.

@sjeguedes
Copy link
Owner Author

sjeguedes commented Nov 13, 2019

Please note that:

  • Entities constructors must be strengthen quickly (asserts and data check).
  • composer.json file have to be updated to 4.2.4 and maybe think about upgrade Symfony version to 4.3/4.4.
  • SessionTrait has no utility and must be deleted after UserManager update (it uses this Trait!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant