Support for Rails 7.0 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning happened on ruby 2.7.5, did not test 3.0+
Rails 5.2 does not work for ruby 3+ so we skip it in appraisals
dark-panda
suggested changes
Jan 12, 2022
pg_ltree.gemspec
Outdated
| @@ -18,7 +18,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir['{app,config,db,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.rdoc'] | |||
| s.test_files = Dir['test/**/*'] | |||
|
|
|||
| s.add_dependency 'activerecord', '>= 4.0.0', '<= 7.0.0.rc1' | |||
| s.add_dependency 'activerecord', '>= 5.2', '<= 7.0' | |||
There was a problem hiding this comment.
Shouldn't this be < 8, otherwise you can't do, say, Rails 7.0.1, only 7.0.0 exactly.
There was a problem hiding this comment.
I wasn't sure if you would want to allow support for 7.1 without testing first? But this probably wouldn't allow 7.0.1, so should change regardless. I'll change it to < 8
sjke
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, sorry for not reaching out before making changes, but I was upgrading some of my stuff to Rails 7 and ran into issues with this gem. I made more changes than strictly necessary because I was getting errors trying to use the rake task as they were, so that is why I added the appraisal gem.