Shall we include integration tests into coverage report?

[vogdb]

Just a thought to think of.

[vogdb]

We have unit and integration tests. There is a coverage report for unit. Shall we have coverage for integration? Shall we merge both reports in the end? Problem is that integration tests use dist/ and unit tests use src/.

[vogdb]

Current combine solutions treat reports for dist/ and src/ as for different sources, so no possibility to merge those reports, only to calculate their average coverage.

So, no point in including the coverage of integration tests into the codecov final report.

We just need to be sure that when we run test-codecov on CI, we also run integration tests without coverage.

[vogdb]

@zazabe please review

[vogdb]

@zazabe please hold

[vogdb]

@ppp0 need your opinion here. Is it possible to run integration tests on Travis? They require a running vagrant machine.

[ppp0]

They require a running vagrant machine.

Who requires an additional VM:

• Travis CI?
• the tests?

Consider that Virtualbox can't run inside Travis - because it's a virtualized machine there, too.
I really like the proposed direction in here: travis-ci/travis-ci#6060 (comment)

We do have a vagrant box version for Amazon EC2 where one could run janus standalone and have the tests connect to it.

Mocking the traffic would be a feasible solution? Probably difficult... or you know some nice tools?

[zazabe]

Is it possible to use https://docs.travis-ci.com/user/docker/, with https://hub.docker.com/r/jess/chrome/ for example?

[ppp0]

Interesting @zazabe !

• chrome/chromedriver: something like https://hub.docker.com/r/robcherry/docker-chromedriver/
• janus standalone.. there are some builds (https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=janus&starCount=0) but I think we'd be better off by providing our own janus container

[vogdb]

Who requires an additional VM:

• Travis CI?
• the tests?

the tests.

So, shall we use Docker instead of Vagrant in this project? @ppp0 @zazabe

[ppp0]

Would be really cool to have a containerized janus-gateway (there are a few around already but they were not invented here plus they might not be configured the way we want) see https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=janus&starCount=0

[vogdb]

So, shall we use Docker instead of Vagrant in this project? @ppp0 @zazabe

@njam please share your thoughts too

[njam]

Tomasz and I created a docker container of our janus-gateway puppet modules during research day: https://github.com/cargomedia/docker-images
It uses our Puppet modules to install and configure the software, so it's exactly the same setup, including our plugins that we use (rtpbroadcast, audioroom).

[ppp0]

Nice! As soon as I have some time, I would like to look into this issue!

[njam]

Closing due to #99