Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we include integration tests into coverage report? #71

Closed
wants to merge 2 commits into from

Conversation

vogdb
Copy link
Collaborator

@vogdb vogdb commented Jul 22, 2016

Just a thought to think of.

@vogdb vogdb self-assigned this Jul 22, 2016
@vogdb
Copy link
Collaborator Author

vogdb commented Jul 22, 2016

We have unit and integration tests. There is a coverage report for unit. Shall we have coverage for integration? Shall we merge both reports in the end? Problem is that integration tests use dist/ and unit tests use src/.

@vogdb
Copy link
Collaborator Author

vogdb commented Jul 22, 2016

Current combine solutions treat reports for dist/ and src/ as for different sources, so no possibility to merge those reports, only to calculate their average coverage.
screen shot 2016-07-22 at 15 39 39

So, no point in including the coverage of integration tests into the codecov final report.

We just need to be sure that when we run test-codecov on CI, we also run integration tests without coverage.

@vogdb
Copy link
Collaborator Author

vogdb commented Jul 22, 2016

@zazabe please review

@vogdb
Copy link
Collaborator Author

vogdb commented Jul 22, 2016

@zazabe please hold

@vogdb
Copy link
Collaborator Author

vogdb commented Jul 22, 2016

@ppp0 need your opinion here. Is it possible to run integration tests on Travis? They require a running vagrant machine.

@ppp0
Copy link
Collaborator

ppp0 commented Jul 25, 2016

They require a running vagrant machine.

Who requires an additional VM:

  • Travis CI?
  • the tests?

Consider that Virtualbox can't run inside Travis - because it's a virtualized machine there, too.
I really like the proposed direction in here: travis-ci/travis-ci#6060 (comment)

We do have a vagrant box version for Amazon EC2 where one could run janus standalone and have the tests connect to it.

Mocking the traffic would be a feasible solution? Probably difficult... or you know some nice tools?

@zazabe
Copy link
Contributor

zazabe commented Jul 25, 2016

Is it possible to use https://docs.travis-ci.com/user/docker/, with https://hub.docker.com/r/jess/chrome/ for example?

@ppp0
Copy link
Collaborator

ppp0 commented Jul 25, 2016

Interesting @zazabe !

@vogdb
Copy link
Collaborator Author

vogdb commented Aug 1, 2016

Who requires an additional VM:

  • Travis CI?
  • the tests?

the tests.

So, shall we use Docker instead of Vagrant in this project? @ppp0 @zazabe

@ppp0
Copy link
Collaborator

ppp0 commented Aug 1, 2016

Would be really cool to have a containerized janus-gateway (there are a few around already but they were not invented here plus they might not be configured the way we want) see https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=janus&starCount=0

@vogdb
Copy link
Collaborator Author

vogdb commented Aug 1, 2016

So, shall we use Docker instead of Vagrant in this project? @ppp0 @zazabe

@njam please share your thoughts too

@njam
Copy link
Contributor

njam commented Aug 1, 2016

Tomasz and I created a docker container of our janus-gateway puppet modules during research day: https://github.com/cargomedia/docker-images
It uses our Puppet modules to install and configure the software, so it's exactly the same setup, including our plugins that we use (rtpbroadcast, audioroom).

@ppp0
Copy link
Collaborator

ppp0 commented Aug 1, 2016

Nice! As soon as I have some time, I would like to look into this issue!

@njam njam mentioned this pull request Sep 15, 2016
@njam
Copy link
Contributor

njam commented Oct 25, 2016

Closing due to #99

@njam njam closed this Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants