-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shall we include integration tests into coverage report? #71
Conversation
We have unit and integration tests. There is a coverage report for unit. Shall we have coverage for integration? Shall we merge both reports in the end? Problem is that integration tests use |
@zazabe please review |
@zazabe please hold |
@ppp0 need your opinion here. Is it possible to run integration tests on Travis? They require a running vagrant machine. |
Who requires an additional VM:
Consider that Virtualbox can't run inside Travis - because it's a virtualized machine there, too. We do have a vagrant box version for Amazon EC2 where one could run janus standalone and have the tests connect to it. Mocking the traffic would be a feasible solution? Probably difficult... or you know some nice tools? |
Is it possible to use https://docs.travis-ci.com/user/docker/, with https://hub.docker.com/r/jess/chrome/ for example? |
Interesting @zazabe !
|
Would be really cool to have a containerized janus-gateway (there are a few around already but they were not invented here plus they might not be configured the way we want) see https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=janus&starCount=0 |
Tomasz and I created a docker container of our janus-gateway puppet modules during research day: https://github.com/cargomedia/docker-images |
Nice! As soon as I have some time, I would like to look into this issue! |
Closing due to #99 |
Just a thought to think of.