Stack trace on 'Permission Denied'

[kkuchta]

FFind should probably fail a little more gracefully if it hits a directory it doesn't have the permissions to deal with.

➜ ~ mkdir foo
➜ ~ mkdir foo/blah
➜ ~ cd foo
➜ foo chmod 000 blah
➜ foo ffind whatever
Traceback (most recent call last):
File "/usr/local/bin/ffind", line 828, in
main()
File "/usr/local/bin/ffind", line 824, in main
search(query)
File "/usr/local/bin/ffind", line 481, in search
_search(query, '.', 0, get_initial_ignorers())
File "/usr/local/bin/ffind", line 478, in _search
_search(query, d, depth + 1, ignorers)
File "/usr/local/bin/ffind", line 461, in _search
contents = os.listdir(dir)
OSError: [Errno 13] Permission denied: './blah'
➜ foo

(OS X 10.8.1)

[sjl]

Sounds like a good idea. I wonder if I should do what find does and print messages on standard error, or just skip them silently.

I'm leaning toward skipping silently since those messages always annoy the shit out of me when I use find. Maybe a --verbose flag to show them would be useful?

[kkuchta]

Hmm... yeah, it's a tradeoff, since silently skipping them could lead to a frustrating time wondering why something you know is there is not showing up. Since ffind is all about defaults that do what most people want, you're right: silent skipping with a verbose flag to do otherwise is probably the most useful route.

[sjl]

What about a single WARNING: Skipping directories you don't have permission to read
line of output at the end on stderr when that happens by default, not even then
if --quiet, and full warnings when --verbose?

[kkuchta]

Could do. Probably depends on whether you think the main use case is people just searching manually (in which case that's useful) or are piping the output of ffind somewhere (in which case the quite option is probably better).

[NewAlexandria]

bump for quality. My thanks for your work.

[wwwjfy]

committed my initial version for this 1-year-old issue. Just print every error.

@kkuchta for pipes, it's not a problem as stderr won't be piped to stdout pipe unless specified explicitly.