Don't set target element for steps unless it is found #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that serves as a workaround/fix for #12.
Right now it is possible to navigate to a different view or render an element before the next step is loaded via the
onBeforeStepChangeevent. However, when a new element is rendered, it cannot be targeted even ifrefresh()orupdatePositions(). This happens because the target element is undefined (because it does not exist yet) when the steps are initially computed, and recomputing them through a refresh does not work because the target is replaced by theundefinedvalue on the first compute.By simply not setting the target if the element cannot be found during compute, this can be avoided and new elements can easily be targeted after calling
refresh().