removed dependency on bytestring-conversion

[esjmb]

Hi,
I'm suggesting the elimination of the dependency on bytestring-conversion, by replacing the use of Data.ByteString.Conversion.toByteString' with Data.Text.Encoding.encodeUtf8, and using encodeUtf8 directly in the ToHttpApiData Link and [Link] implementations, given that writeLinkHeader and writeLink return Text, and Data.ByteString.Conversion.toByteString' appears to resolve to a call to encodeUtf8 :: Text -> ByteString for Text. This allows the elimination of the ToByteString implementations for Link and [Link], which so far as I can tell are for internal use only.

The dependency on bytestring-conversion happens to be causing a build problem for stack --docker with LTS-13.1. This fix solves that. The dependency on text exists already.

results of stack test suggest no problems:

http-link-header-1.0.3.1: test (suite: tests)
            
Progress 1/2: http-link-header-1.0.3.1
Network.HTTP.Link.Parser
  linkHeader
    parses a single link
    parses empty attributes
    parses custom attributes
    parses backslash escaped attributes
    parses escaped attributes
    parses multiple attributes
    parses custom attributes named similarly to standard ones
    parses unquoted rel, rev attributes
    does not blow up on title*
    parses weird whitespace all over the place
Network.HTTP.Link.Writer
  writeLinkHeader
    writes a single link
    writes params with quote escaping
    writes multiple parameters
    writes custom params
    writes multiple links
Network.HTTP.Link
  writeLinkHeader → parseLinkHeader
    roundtrips successfully
      +++ OK, passed 100 tests.

Finished in 2.5769 seconds
16 examples, 0 failures
                                      
http-link-header-1.0.3.1: Test suite tests passed

thanks,

Stephen.

[valpackett]

I thought bytestring-conversion is the more efficient way, but whatever, less dependencies is good. Just clean up the commit :)

The dependency on bytestring-conversion happens to be causing a build problem for stack --docker with LTS-13.1

The actual problem should be fixed there too, did you report it?

[esjmb]

I thought bytestring-conversion is the more efficient way, but whatever, less dependencies is good. Just clean up the commit :)

The dependency on bytestring-conversion happens to be causing a build problem for stack --docker with LTS-13.1

The actual problem should be fixed there too, did you report it?

So far as I can tell, the problem is with the fpco/stack-build for its 13.x. I've reported it there and I guess stack-build will be able to build byte string-conversion without difficulty in the near future.

There is a thread here: commercialhaskell/stack#4470

That issue led me to spot the unnecessary dependency for servant-auth (haskell-servant/servant-auth#136) , and then your http-link-header.

Quite possible that byte string-conversion is more efficient, I don't know, but from what I can tell, it seems that the servant-auth guys switched out dependency for bytestring-conversion to blaze a while ago.

[valpackett]

Thanks!

[esjmb]

Thanks!

and to you!