-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mfbo optimizer (Sourcery refactored) #6
Improve mfbo optimizer (Sourcery refactored) #6
Conversation
cae63f8
to
a84ddb1
Compare
err = "The utility function " \ | ||
"{} has not been implemented, " \ | ||
"please choose one of ucb, ei, or poi.".format(kind) | ||
err = f"The utility function {kind} has not been implemented, please choose one of ucb, ei, or poi." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function UtilityFunction.__init__
refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting
)
if not (show or save_as): | ||
if not show and not save_as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function plot_multiple_error_grids
refactored with the following changes:
- Simplify if expression by using or [×2] (
or-if-exp-identity
) - Simplify logical expression using De Morgan identities (
de-morgan
) - Swap if/else branches of if expression to remove negation [×2] (
swap-if-expression
)
axes[1].set_title(title + ' log-scale') | ||
axes[1].set_title(f'{title} log-scale') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function plot_extracts
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
ax[1].set_title(title + ' log-scale') | ||
ax[1].set_title(f'{title} log-scale') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function plot_multi_file_extracts
refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.09%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #5 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
improve-mfbo-optimizer
branch, then run:Help us improve this pull request!