Improve mfbo optimizer (Sourcery refactored)

[sourcery-ai]

Pull Request #5 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the improve-mfbo-optimizer branch, then run:

git fetch origin sourcery/improve-mfbo-optimizer
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function UtilityFunction.__init__ refactored with the following changes:

• Replace call to format with f-string. (use-fstring-for-formatting)

[sourcery-ai]

Function plot_multiple_error_grids refactored with the following changes:

• Simplify if expression by using or [×2] (or-if-exp-identity)
• Simplify logical expression using De Morgan identities (de-morgan)
• Swap if/else branches of if expression to remove negation [×2] (swap-if-expression)

[sourcery-ai]

Function plot_extracts refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Function plot_multi_file_extracts refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.09%.

Quality metrics	Before	After	Change
Complexity	9.92 🙂	9.79 🙂	-0.13 👍
Method Length	111.02 🙂	111.02 🙂	0.00
Working memory	12.83 😞	12.83 😞	0.00
Quality	51.63% 🙂	51.72% 🙂	0.09% 👍

Other metrics	Before	After	Change
Lines	1057	1056	-1

Changed files	Quality Before	Quality After	Quality Change
scripts/experiments/2020-11-05-simple-mfbo.py	60.87% 🙂	60.86% 🙂	-0.01% 👎
scripts/processing/processing.py	44.45% 😞	44.61% 😞	0.16% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
scripts/processing/processing.py	plot_error_grid	33 ⛔	593 ⛔	24 ⛔	10.52% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
scripts/experiments/2020-11-05-simple-mfbo.py	Optimizer.iterate	18 🙂	290 ⛔	16 ⛔	28.13% 😞	Try splitting into smaller methods. Extract out complex expressions
scripts/processing/processing.py	plot_multiple_error_grids	18 🙂	232 ⛔	16 ⛔	30.84% 😞	Try splitting into smaller methods. Extract out complex expressions
scripts/processing/processing.py	plot_extracts	13 🙂	217 ⛔	15 😞	36.95% 😞	Try splitting into smaller methods. Extract out complex expressions
scripts/processing/processing.py	plot_multi_file_extracts	10 🙂	238 ⛔	15 😞	38.33% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!