fix(view): stopped prompt increasing parent view size

sjwall · Sep 8, 2018 · c914114 · c914114
1 parent 188f018
commit c914114
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/library/src/main/java/uk/co/samuelwall/materialtaptargetprompt/MaterialTapTargetPrompt.java b/library/src/main/java/uk/co/samuelwall/materialtaptargetprompt/MaterialTapTargetPrompt.java
@@ -770,6 +770,14 @@ public PromptView(final Context context)
             }
         }
 
+        @Override
+        protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec)
+        {
+            // Stop the prompt increasing the parent size by setting it to the parents size.
+            final View parent = (View) this.getParent();
+            this.setMeasuredDimension(parent.getMeasuredWidth(), parent.getMeasuredHeight());
+        }
+
         @Override
         public void onDraw(final Canvas canvas)
         {

diff --git a/.../src/main/java/uk/co/samuelwall/materialtaptargetprompt/sample/DialogFragmentExample.java b/.../src/main/java/uk/co/samuelwall/materialtaptargetprompt/sample/DialogFragmentExample.java
@@ -63,8 +63,8 @@ public void showFragmentFabPrompt()
         new MaterialTapTargetPrompt.Builder(this)
                 .setTarget(R.id.fab)
                 .setAnimationInterpolator(new FastOutSlowInInterpolator())
-                .setPrimaryText("Clipped to activity bounds")
-                .setSecondaryText("The prompt does not draw outside the activity")
+                .setPrimaryText("Clipped to dialog bounds")
+                .setSecondaryText("The prompt does not draw outside the dialog")
                 .show();
     }
 }
diff --git a/...in/java/uk/co/samuelwall/materialtaptargetprompt/sample/SupportDialogFragmentExample.java b/...in/java/uk/co/samuelwall/materialtaptargetprompt/sample/SupportDialogFragmentExample.java
@@ -61,8 +61,8 @@ public void showFragmentFabPrompt()
         new MaterialTapTargetPrompt.Builder(this)
                 .setTarget(R.id.fab)
                 .setAnimationInterpolator(new FastOutSlowInInterpolator())
-                .setPrimaryText("Clipped to activity bounds")
-                .setSecondaryText("The prompt does not draw outside the activity")
+                .setPrimaryText("Clipped to dialog bounds")
+                .setSecondaryText("The prompt does not draw outside the dialog")
                 .show();
     }
 }