different device size issue

[MahdiTaghipour]

Hi,
I have problem using this library with different screen sizes. on a 7" tablet, the texts falls outside the box from left or right, while there is no problem with a 5.7" device. How can i handle this issue. i have to mention that,this occurs rarely and only some text in some positions behave in this manner.
thanks in advance.

[sjwall]

Probably related to #41 please try v1.9.1 and let me know if it fixes it for you

[MahdiTaghipour]

no it is not fixed in the new version.

[sjwall]

Could you please provide the Android version that this is effecting and the target position on screen, so that I can investigate further. Thanks

[MahdiTaghipour]

I see this issue on a 7" tablet with android version of 17.
my app is multilingual and the problem occurs in persian(farsi) language. I think it is some thing related to language of app.

[amalkh5]

Also, i get this problem in Nexus 6p
my Langage is Arabic

[sjwall]

The fix for this has been released in v1.9.3. If you are still having issues please reopen this bug. Thanks

[amalkh5]

yes I still get this problem also in different device screen sizes like 9 and 5

[sjwall]

It looks like it is an issue with detecting how long the text is with different language alphabets,

[MahdiTaghipour]

The problem remains in new version.

[sjwall]

Changes made in release v1.9.4 should fix this issue. If not please reopen. Thanks

[FrangSierra]

Sadly im having this problem on one of my devices. Texts from left to right are falling outside the view. It just happend in an specific case.

I'm using the library from Kotlin, but I think that it should no affect it.

    private fun createDefaultStyleMaterialTarget(title: String, content: String, view: View, activity: Activity, onClick: () -> Unit = {}) =
            MaterialTapTargetPrompt.Builder(activity)
                    .setAnimationInterpolator(FastOutSlowInInterpolator())
                    .setPrimaryTextColour(activity.color(R.color.color_accent))
                    .setSecondaryTextSize(activity.resources.getDimension(R.dimen.default_tutorial_text_size))
                    .setFocalColour(activity.color(R.color.color_app_grey))
                    .setBackgroundColour(activity.color(R.color.tutorial_background_black))
                    .setSecondaryText(content)
                    .setPrimaryText(title)
                    .setPromptBackground(CustomCirclePromptBackground())
                    .setCaptureTouchEventOnFocal(true)
                    .setCaptureTouchEventOutsidePrompt(true)
                    .setMaxTextWidth(R.dimen.tap_target_menu_max_width)
                    .setPromptStateChangeListener { _, state ->
                        if (state == MaterialTapTargetPrompt.STATE_FOCAL_PRESSED || state == STATE_NON_FOCAL_PRESSED) {
                            onClick()
                        }
                    }
                    .setTarget(view)

I have follow the error to the CirclePromptBackground to line 131. Where it should calculate the length based on the textBounds and the focalBounds. At this position the focalBounds is bigger than the textBounds(when it shouldn't).

If I reverse this if clase this case works, but ofc i broke the rest of my implementations with the library 😅 . I'm gonna try to fix it and upload a PR to the library, but my knowledge about custom views is not so great.

Hope that you will fix it soon! Your library is amazing! Thank you mate

[FrangSierra]

Opened a PR that fix the problem making easier and safer the way that the CirclePromptBackground measures the right length
#116

[sjwall]

I have found an issue when the target is wider that the text size it is calculating the size incorrectly but it doesn't explain what you are seeing, looking into it

[sjwall]

The changes have been released in v2.9.0.
If the issue persists please reopen and provide the following:

• screen bounds(left, top, right, bottom) clipBounds
• focal bounds(left, top, right, bottom) focalBounds
• focal padding focalPadding
• text bounds(left, top, right, bottom) textBounds
• text padding textPadding

These can be obtained by putting a break point on line 113 in CirclePromptBackground.java

With these values I can put them in the tool I have created here to figure out exactly how the calculations are being made

Thanks