Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FragmentContainerView as parent #180

Merged
merged 2 commits into from Oct 23, 2020
Merged

Conversation

JMavrelos
Copy link
Contributor

Now checks if the parent is a FragmentContainerView when retrieving parent in getPromptParentView

if it is it goes up levels until it finds one that isn't

Now checks if the parent is a FragmentContainerView when retrieving parent in getPromptParentView

if it is it goes up levels until it finds one that isn't
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #180 into master will decrease coverage by 0.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   93.03%   92.89%   -0.14%     
==========================================
  Files          21       21              
  Lines        1292     1295       +3     
  Branches      148      149       +1     
==========================================
+ Hits         1202     1203       +1     
- Misses         74       75       +1     
- Partials       16       17       +1     
Impacted Files Coverage Δ
...taptargetprompt/SupportFragmentResourceFinder.java 87.50% <50.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71d268...3c4679e. Read the comment docs.

sjwall added a commit that referenced this pull request Oct 23, 2020
@sjwall sjwall changed the title Issue 179 fix: FragmentContainerView as parent Oct 23, 2020
@sjwall sjwall merged commit 4c3234c into sjwall:master Oct 23, 2020
@sjwall
Copy link
Owner

sjwall commented Oct 23, 2020

Thanks for the PR

@JMavrelos JMavrelos deleted the Issue_179 branch October 23, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants