Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prompt not updating when target view moves #95

Merged
merged 2 commits into from Dec 20, 2017
Merged

Fixed prompt not updating when target view moves #95

merged 2 commits into from Dec 20, 2017

Conversation

SUPERCILEX
Copy link
Contributor

This redoes fddc186 but without #94. The problem was that animationCurrent could have greater than 1f values.

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #95 into master will decrease coverage by 0.07%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
- Coverage     95.87%   95.79%   -0.08%     
- Complexity      324      325       +1     
============================================
  Files            14       14              
  Lines          1017     1023       +6     
  Branches        117      119       +2     
============================================
+ Hits            975      980       +5     
  Misses           21       21              
- Partials         21       22       +1
Impacted Files Coverage Δ Complexity Δ
...terialtaptargetprompt/MaterialTapTargetPrompt.java 88.92% <92.3%> (-0.12%) 40 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121f93f...c3c41cd. Read the comment docs.

@sjwall
Copy link
Owner

sjwall commented Dec 14, 2017

I shall review this tomorrow, thanks for the PR :)

@SUPERCILEX
Copy link
Contributor Author

@sjwall Gentle ping. 😄

@sjwall sjwall merged commit 99c6342 into sjwall:master Dec 20, 2017
@sjwall
Copy link
Owner

sjwall commented Dec 20, 2017

LGTM, been a bit under the weather so not had chance till now :)

@SUPERCILEX SUPERCILEX deleted the position branch December 20, 2017 20:20
@SUPERCILEX
Copy link
Contributor Author

@sjwall Oh, hope you get well soon and no problem. We'll all be OOO soon anyway! 😁

@sjwall
Copy link
Owner

sjwall commented Dec 20, 2017

Thanks

@SUPERCILEX SUPERCILEX changed the title Fix prompt not updating its position Fixed prompt not updating when target view moves Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants