Bind to event other than native scroll #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives us the option of monitoring an event other than native scroll to check for updates.
This is useful in cases, like at The New York Times, where we already have a view that is monitoring scroll events and dispatching its own, throttled version of scroll. I'd rather subscribe to these site-wide events than attach an additional handler to the scroll. Here's the exact implementation I'm developing against:
The new
scrollEvent
option can be a function that calls the update method as a callback, like the example above, or a string that specifies an event on the window to listen for. The default is the string 'scroll', which gets translated to our current technique, monitoring $(window).scroll() with a throttle determined byscrollSensitivity
andthrottleType
.If another string is passed in, we monitor the window for that event. Something like this: