Skip to content

Commit

Permalink
Fixed last failing test in 2.6, fixed travis to support 2.5
Browse files Browse the repository at this point in the history
  • Loading branch information
sk- committed Aug 15, 2014
1 parent 1f942e3 commit 19235ed
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ python:
install:
- "pip install ."
- "pip install unittest2"
- "pip install coveralls"
- "if [[ $TRAVIS_PYTHON_VERSION != '2.5' ]]; then pip install coveralls; fi"
# command to run tests
script: python test_collections.py
after_success:
coveralls
"if [[ $TRAVIS_PYTHON_VERSION != '2.5' ]]; then coveralls; fi"
2 changes: 2 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Known Issues

* In Python 2.6 Issue 9137 is not solved as it complains if it gets a keyword
argument named ``self``. The error is ``TypeError: update() got multiple values for keyword argument 'self'``.
Additionally the keyword argument cannot be called ``other`` either as it will think it is the full dict. No error is raised in this case.


License
-------
Expand Down
6 changes: 3 additions & 3 deletions test_collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,9 @@ def test_update(self):
#od = OrderedDict()
#od.update(self=23)
#self.assertEqual(list(od.items()), [('self', 23)])
od = OrderedDict()
od.update(other={})
self.assertEqual(list(od.items()), [('other', {})])
#od = OrderedDict()
#od.update(other={})
#self.assertEqual(list(od.items()), [('other', {})])
od = OrderedDict()
od.update(red=5, blue=6, other=7, self=8)
self.assertEqual(sorted(list(od.items())),
Expand Down

0 comments on commit 19235ed

Please sign in to comment.