This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Allow git-lint to check branches #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougalg
force-pushed
the
branch-diff
branch
4 times, most recently
from
a147130
to
e9e278c
Compare
|
Looks like there's still a couple of failures in the end to end tests. Not sure how to resolve those. @sk- if you can provide any insight? |
This modified the behaviour (for Git only) to accept --branch specifier which will allow users to get linting diffs between branches.Useful for testing after commits and PRs have been made. This also now gives the ability (for git) to test arbitrary commit distances apart (although that UI is not implemented here)
|
@sk- Would like to see this added. Would be super useful to check against PRs in Travis builds. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the behaviour (for Git only) to accept --branch specifier which will allow users to get linting diffs between branches.Useful for testing after commits and PRs have been made. This also now gives the ability (for git) to test arbitrary commit distances apart (although that UI is not implemented here)
I've had some trouble running the tests, but I think I'm getting closer to having them fixed up soon. Also, I don't consider this complete, but would like to get feedback on what you think of my approach here before I go any further.
Thanks for the great tool and hopefully you find this concept useful!