This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Support multi-file input #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
force-pushed
the
support-directory-globbing
branch
16 times, most recently
from
fc9781e
to
7e3d025
Compare
|
|
||
| path = options['FILENAME'] | ||
| is_file = os.path.isfile(path) | ||
| html_files = [path] if is_file else glob.glob('{}/*.html'.format(path)) |
There was a problem hiding this comment.
html is not the only extension that should be supported, htm and many template extensions should be supported as well.
Also, this is counterintuitive, as there is no recursion.
My opinion is that instead of supporting directories we could support multiple filenames.
di
force-pushed
the
support-directory-globbing
branch
from
7e3d025
to
ea48dfc
Compare
di
force-pushed
the
support-directory-globbing
branch
3 times, most recently
from
056608d
to
fdab0d2
Compare
|
@sk- I addressed your feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to give the
html_lint.pycommand multiple input files instead of a single file, e.g.: