Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button being unchecked when collapsed #16

Closed
MattApril opened this issue Apr 22, 2021 · 4 comments
Closed

Radio button being unchecked when collapsed #16

MattApril opened this issue Apr 22, 2021 · 4 comments

Comments

@MattApril
Copy link

Steps to recreate:

  1. Add a radio button inside of a collapse container.
  2. check the radio button
  3. collapse the container and expand it again.

Expected result: the radio button is still checked
Actual result: the radio button is no longer checked

I discovered this bug in Chrome, but it does not happen in Safari. I did not test any other browsers. Only seems to affect radio buttons - no other input element. I suspected this could be some kind of chrome bug/feature, but I tested with some other collapse libraries and could not reproduce it.

@MattApril
Copy link
Author

I just realized that I definitely have other radio buttons inside of collapse containers in my app, and they work fine. But I was able to recreate this directly on the demo website https://handy-collapse.netlify.app/, so I still think something is up. I will dig more and see what I can figure out..

sk-rt added a commit that referenced this issue May 8, 2021
fix: Radio button being unchecked when collapsed #16
@sk-rt
Copy link
Owner

sk-rt commented May 8, 2021

@MattApril Thanks for reporting the issue.
This was a bug with element.cloneNode().
This issue will be fixed in the next release.

@sk-rt
Copy link
Owner

sk-rt commented May 8, 2021

This issue was fixed on v1.0.4.

@sk-rt sk-rt closed this as completed May 8, 2021
@MattApril
Copy link
Author

Awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants