swap order of checks

since a boolean check is faster than getting inventory item + string comparison
EngineHub · Apr 3, 2019 · 9ba1121 · 9ba1121
1 parent 3d2054a
commit 9ba1121
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/PlatformManager.java b/worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/PlatformManager.java
@@ -321,11 +321,7 @@ public void handleBlockInteract(BlockInteractEvent event) {
 
             try {
                 if (event.getType() == Interaction.HIT) {
-                    if (player.getItemInHand(HandSide.MAIN_HAND).getType().getId().equals(getConfiguration().wandItem)) {
-                        if (!session.isToolControlEnabled()) {
-                            return;
-                        }
-
+                    if (session.isToolControlEnabled() && player.getItemInHand(HandSide.MAIN_HAND).getType().getId().equals(getConfiguration().wandItem)) {
                         if (!actor.hasPermission("worldedit.selection.pos")) {
                             return;
                         }
@@ -341,7 +337,7 @@ public void handleBlockInteract(BlockInteractEvent event) {
                         return;
                     }
 
-                    if (player.isHoldingPickAxe() && session.hasSuperPickAxe()) {
+                    if (session.hasSuperPickAxe() && player.isHoldingPickAxe()) {
                         final BlockTool superPickaxe = session.getSuperPickaxe();
                         if (superPickaxe != null && superPickaxe.canUse(player)) {
                             event.setCancelled(superPickaxe.actPrimary(queryCapability(Capability.WORLD_EDITING), getConfiguration(), player, session, location));
@@ -358,11 +354,7 @@ public void handleBlockInteract(BlockInteractEvent event) {
                     }
 
                 } else if (event.getType() == Interaction.OPEN) {
-                    if (player.getItemInHand(HandSide.MAIN_HAND).getType().getId().equals(getConfiguration().wandItem)) {
-                        if (!session.isToolControlEnabled()) {
-                            return;
-                        }
-
+                    if (session.isToolControlEnabled() && player.getItemInHand(HandSide.MAIN_HAND).getType().getId().equals(getConfiguration().wandItem)) {
                         if (!actor.hasPermission("worldedit.selection.pos")) {
                             return;
                         }