Check number of keys

ska-sa · Feb 12, 2018 · fa252bc · bmerry · Feb 12, 2018 · fa252bc
1 parent b2b6786
commit fa252bc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/fakenewsredis.py b/fakenewsredis.py
@@ -705,6 +705,9 @@ def sort(self, name, start=None, num=None, by=None, get=None, desc=False,
     def eval(self, script, numkeys, *keys_and_args):
         from lupa import LuaRuntime, LuaError
 
+        if numkeys > len(keys_and_args):
+            raise ResponseError("Number of keys can't be greater than number of args")
+
         lua_runtime = LuaRuntime(unpack_returned_tuples=True)
 
         set_globals = lua_runtime.eval(

diff --git a/test_fakenewsredis.py b/test_fakenewsredis.py
@@ -3168,6 +3168,10 @@ def test_eval_runtime_error(self):
         with self.assertRaises(ResponseError):
             self.redis.eval('error("CRASH")', 0)
 
+    def test_more_keys_than_args(self):
+        with self.assertRaises(ResponseError):
+            self.redis.eval('return 1', 42)
+
     def test_eval_global_variable(self):
         # Redis doesn't allow script to define global variables
         with self.assertRaises(ResponseError):