New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update casacore to 3.1.1 and make less version needy #19
Commits on Dec 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8003fd2 - Browse repository at this point
Copy the full SHA 8003fd2View commit details
Commits on Dec 13, 2018
-
Apply temporary Boost Python patch
Boost 1.67 Python components require a Python version suffix. The logic for this was added to the CMake machinery of the upstream library in casacore/casacore#846, but this won't make it into a release for a while. Add a patch in the meantime, to be removed on the next release.
Configuration menu - View commit details
-
Copy full SHA for 4cc9f8c - Browse repository at this point
Copy the full SHA 4cc9f8cView commit details
Commits on May 17, 2019
-
casacore: Improve dependencies and flags
The wcslib formula moved back to homebrew/core in July 2018 after brewsci grew stale. The boost-python library for Python 3 has a separate formula since 1.66.0 (Feb 2018). Restore gcc dependency since casacore looks for a Fortran compiler during cmake configure. Since casacore 3.0 it is now mandatory to use C++11 features (see casacore/casacore#580). Also ensure that undefined symbols are ignored until runtime in the Python shared library.
Configuration menu - View commit details
-
Copy full SHA for b2fad8f - Browse repository at this point
Copy the full SHA b2fad8fView commit details -
Move boost-python patch to GitHub gist
Only apply the patch to current releases (3.0 and 3.1). The HEAD and future 3.2 release already has it (due to casacore/casacore#846).
Configuration menu - View commit details
-
Copy full SHA for f72c661 - Browse repository at this point
Copy the full SHA f72c661View commit details -
Use FindPython2, FindPython3 modules of cmake 3.12
These provide more robust detection of Python versions on macOS and replace the functionality of casacore's FindPython.cmake and FindNUMPY.cmake. Previously the Homebrew Python 3 include dirs were confused with those of Homebrew Python 2. There is also no need to hardcode the Python executable and library (always a bad idea). While these modules are available since cmake 3.12, they could be copied to casacore and still run on cmake 3.7, in case the bigger project has need of them.
Configuration menu - View commit details
-
Copy full SHA for e6529d9 - Browse repository at this point
Copy the full SHA e6529d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 462adc5 - Browse repository at this point
Copy the full SHA 462adc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f02155d - Browse repository at this point
Copy the full SHA f02155dView commit details -
Redo patches to work with latest HEAD
The stable patch turns v3.0.0 into c349f27, effectively applying #846. The original patch only included the first commit of this PR (d'oh). The cmake patch now applies on top of #846 and also works on the latest HEAD.
Configuration menu - View commit details
-
Copy full SHA for c2ec22f - Browse repository at this point
Copy the full SHA c2ec22fView commit details -
Remove a non-existent option for dependency
The boost-python3 formula has no --with-python option (that sounds tautological anyway).
Configuration menu - View commit details
-
Copy full SHA for 17ec2fb - Browse repository at this point
Copy the full SHA 17ec2fbView commit details
Commits on May 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for da867b7 - Browse repository at this point
Copy the full SHA da867b7View commit details -
casacore: make Python 2 support mandatory
Follow the "Python for Formula Authors" document, which states that 'Python 2 libraries do not need a depends_on "python@2" declaration; they will be built with the system Python, but should still be usable with any other Python 2.7.' Thereby make the optional python@2 support mandatory, since system Python 2.7 is always available.
Configuration menu - View commit details
-
Copy full SHA for 2189284 - Browse repository at this point
Copy the full SHA 2189284View commit details
Commits on May 28, 2019
-
casacore: Fix HEAD and unify patch for v3.1.0
The HEAD no longer needs a patch (although it is currently running off a feature branch to be merged as casacore/casacore#922). Now use a single patch that turns v3.1.0 into HEAD (at least as far as the Python build scripts are concerned).
Configuration menu - View commit details
-
Copy full SHA for 13426d2 - Browse repository at this point
Copy the full SHA 13426d2View commit details
Commits on Jun 5, 2019
-
Thanks to casacore/casacore#922 we can also drop all the patches.
Configuration menu - View commit details
-
Copy full SHA for 4d13249 - Browse repository at this point
Copy the full SHA 4d13249View commit details