SPR1-2367: Remove IMAGING_WEIGHT column from MS #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This column is initialised full of zeroes and just takes up space (4 bytes per main table entry, i.e. time-frequency-baseline cell, so about 6-12% overhead). It can be recreated in CASA at a later stage. The column is a leftover of good old blank.ms, which included it along with MODEL_DATA and CORRECTED_DATA. The latter two columns were made optional in the sneaky 41af4b8 as part of #75 in version 0.9, but this one was missed. Also remove the commented-out code that has tagged along forever :-)
Also add some todo's to improve the API of this bit of katdal.
Jordatious
approved these changes
Jul 13, 2022
|
Looks good! Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This column is initialised full of zeroes and just takes up space (4 bytes per main table entry, i.e. time-frequency-baseline cell, so about 6-12% overhead). It can be recreated in CASA at a later stage.
The column is a leftover of good old
blank.ms, which included it along withMODEL_DATAandCORRECTED_DATA. The latter two columns were made optional in the sneaky 41af4b8 as part of #75 in version 0.9, but this one was missed.Testing an MS produced by the new code would be much appreciated.