Add type annotations #101
Merged
Add type annotations #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also picked up a few bugs: - load_from_file would try to transfer expiry times back into redis, but did so incorrectly (confusing absolute and relative times). This is not an issue in practice since we don't use expiry times. - Calling get_range on an indexed key in a MemoryBackend would not raise ImmutableKeyError, and would probably crash out with some other error.
This tells mypy that katsdptelstate has type annotations.
mypy 0.770 was already passing, but adding some annotations for mypy 0.720.
Should be redis.client.Script - it doesn't get exported to the root namespace.
ludwigschwardt
approved these changes
May 8, 2020
| self.ts.test_key = 'foo' | ||
| self.assertEqual(self.ts['test_key'], 'foo') | ||
| self.assertEqual(self.ts.key_type('test_key'), KeyType.IMMUTABLE) | ||
| with self.assertRaises(AttributeError): | ||
| self.ts.root = 'root is a method' | ||
| self.ts.root = 'root is a method' # type: ignore |
There was a problem hiding this comment.
Out of interest, why do you ignore types here?
There was a problem hiding this comment.
Mypy doesn't like one assigning an instance member that shadows a method of the class.
| @@ -23,6 +23,7 @@ | |||
| import threading | |||
There was a problem hiding this comment.
I thought this file looked new... great idea (wrong PR, I know)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd sprinkled a few on to new code, but now I've gone through and done it properly. I wanted to do this now before doing async telstate, because async telstate is going to start by copying a lot of code then sprinkling
asyncs andawaits on it, so it's less effort to do this first than try to add the annotations to both sync and async versions.