Fix mem_reader to stop gracefully #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was directly calling `stop` on the stream. This is equivalent to the user calling it, which is normally a hard stop e.g. if it is a ring_stream, it will stop the ringbuffer without pushing any incomplete heaps into it, or whatever flushing a subclass has implemented in its `stop_received` overload. Instead, use `add_packet_state.stop`, which is what's normally called for a stop triggered by the stream itself (for example, a stop heap or end-of-file in a pcap file), which indirectly calls `stop_received` on the stream.
james-smith-za
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was directly calling
stopon the stream. This isequivalent to the user calling it, which is normally a hard stop e.g. if
it is a ring_stream, it will stop the ringbuffer without pushing any
incomplete heaps into it, or whatever flushing a subclass has
implemented in its
stop_receivedoverload.Instead, use
add_packet_state.stop, which is what's normally calledfor a stop triggered by the stream itself (for example, a stop heap or
end-of-file in a pcap file), which indirectly calls
stop_receivedonthe stream.