Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an asyncio.InvalidStateError #184

Merged
merged 1 commit into from Apr 7, 2022
Merged

Fix an asyncio.InvalidStateError #184

merged 1 commit into from Apr 7, 2022

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Apr 6, 2022

It occurs when the future returned by async_send_heap or
async_send_heaps is cancelled before it completes.

Also fixed another potential instance with cancelling TcpStream.connect,
although it hasn't been observed yet.

It occurs when the future returned by `async_send_heap` or
`async_send_heaps` is cancelled before it completes.

Also fixed another potential instance with cancelling TcpStream.connect,
although it hasn't been observed yet.
@bmerry
Copy link
Contributor Author

bmerry commented Apr 6, 2022

@amishatishpatel could you check if this solves your InvalidStateError in NGC-536?

Copy link
Contributor

@amishatishpatel amishatishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and confirmed to be working. Thank you!

@bmerry bmerry merged commit a39b541 into master Apr 7, 2022
@bmerry bmerry deleted the cancel-async-send-heap branch April 7, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants