Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wheel from build-system.requires #231

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Remove wheel from build-system.requires #231

merged 1 commit into from
Aug 3, 2023

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Aug 3, 2023

See https://setuptools.pypa.io/en/latest/userguide/quickstart.html, which says

Historically this documentation has unnecessarily listed wheel in the
requires list, and many projects still do that. This is not recommended.
The backend automatically adds wheel dependency when it is required, and
listing it explicitly causes it to be unnecessarily required for source
distribution builds. You should only include wheel in requires if you
need to explicitly access it during build time (e.g. if your project
needs a setup.py script that imports wheel).

See https://setuptools.pypa.io/en/latest/userguide/quickstart.html,
which says

> Historically this documentation has unnecessarily listed wheel in the
> requires list, and many projects still do that. This is not recommended.
> The backend automatically adds wheel dependency when it is required, and
> listing it explicitly causes it to be unnecessarily required for source
> distribution builds. You should only include wheel in requires if you
> need to explicitly access it during build time (e.g. if your project
> needs a setup.py script that imports wheel).
@bmerry bmerry merged commit 341e6f4 into master Aug 3, 2023
22 checks passed
@bmerry bmerry deleted the remove-wheel branch August 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants