Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the noisy logging in the tango device #138

Conversation

kmadisa
Copy link
Contributor

@kmadisa kmadisa commented May 20, 2021

This usually occurs in the attribute's write methods. If the attribute gets written frequently it results in a lot of noise in the logs.

Screenshots or code snippets (if appropriate):

Screenshot from 2021-05-20 15-57-39

Definition of Done Checklist

  • Code meets our python style guidelines?
  • Unit tested (coded, passed, included)?
  • Requested at least 2 reviewers?
  • Commented code, particularly in hard-to-understand areas?
  • Made corresponding changes to the documentation (e.g. Python documentation, System Engineering Documentation, version description updates, README file, etc)?

(SKA) JIRA: SAR-233

This usually occurs in the attribute's write methods. If the attribute gets written frequently it results in a lot of noise in the logs.

(SKA) JIRA: (SAR-233)[https://jira.skatelescope.org/browse/SAR-233]
@kmadisa kmadisa self-assigned this May 20, 2021
@kmadisa kmadisa requested a review from samueltwum1 May 20, 2021 14:17
Copy link
Contributor

@samueltwum1 samueltwum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmadisa kmadisa merged commit d903de5 into master May 20, 2021
@kmadisa kmadisa deleted the user/kmadisa/SAR-233/Remove-logging-in-the-attribute-write-methods branch May 20, 2021 14:20
vla22 pushed a commit to ska-telescope/tmc-prototype that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants