Updated the class instance prefix to be more definitive #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the startswith method is called with the prefix 'Sim' it resulted to true for 'SimControl'. This results in the sim_actions not getting overriden with the correct action_handler as it is not defined in the provided 'SimControl' class. This is why only one of the devices' commands where getting overriden. Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
This is just to ensure that commands in both the sim device and the sim control device get overridden, respectively. Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
kmadisa
commented
Dec 4, 2021
This is to ensure that we only get the class instance for simulator device. Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
samueltwum1
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
startswithmethod is called with the prefix 'Sim' it resulted toTruefor 'SimControl'. This results in the action handlers insim_actionsnot getting overridden with the correctaction_handleras it is not defined in the provided 'SimControl' class.This is why only one of the devices' commands where getting overridden.
I also added a test just to make sure that we can execute commands in both the simulator and the simulator controller.
Signed-off-by: Katleho Madisa katleho.madisa47@gmail.com
Screenshots or code snippets (if appropriate):
Definition of Done Checklist
JIRA: N/A