Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAR-393 Reduce logs spewed by device servers #148

Merged
merged 11 commits into from Jun 3, 2022
Merged

SAR-393 Reduce logs spewed by device servers #148

merged 11 commits into from Jun 3, 2022

Conversation

kmadisa
Copy link
Contributor

@kmadisa kmadisa commented May 31, 2022 •
edited

This change reduces the number of log entries made per attribute data parsed. I have change the log level of some log entries from INFO level to DEBUG level.
The rest of the other changes are just a result of applying the black formattor.

Screenshots or code snippets (if appropriate):
N/A

Definition of Done Checklist

  • Code meets our python style guidelines?
  • Unit tested (coded, passed, included)?
  • Requested at least 2 reviewers?
  • Commented code, particularly in hard-to-understand areas?
  • Made corresponding changes to the documentation (e.g. Python documentation, System Engineering Documentation, version description updates, README file, etc)?

JIRA: (SKA) SAR-393

@kmadisa
SAR-393 Reduced the logs emitted by the file parsers
8f9a94d 
Also changed the log level used by the parsers from info -> debug level.

Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
@kmadisa
SAR-939 Fixed linting issues
8aa32cf 
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
@kmadisa
SAR-939 Fixed docstring line lengths
787aa48 
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
kmadisa and others added 3 commits June 2, 2022 15:42
@kmadisa
SAR-393 Updated the log string
bdbfde2
@kmadisa
SAR-393 Added a check before logging
a40f8e0 
This is to ensure we do not log when the list/set of invalid command properties is empty.

Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
@kmadisa
Merge branch 'kmadisa/SAR-393/Reduce-logs-spewed-by-device-servers' of …
5ecdb98 
…https://github.com/ska-sa/tango-simlib into kmadisa/SAR-393/Reduce-logs-spewed-by-device-servers
@kmadisa kmadisa self-assigned this Jun 2, 2022
@kmadisa kmadisa marked this pull request as ready for review June 2, 2022 13:55
SKAJohanVenter
SKAJohanVenter approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@SKAJohanVenter SKAJohanVenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should help a lot with the volume of logs

samueltwum1
samueltwum1 approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@samueltwum1 samueltwum1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged if the pipeline passes.

tango_simlib/utilities/fandango_json_parser.py Outdated Show resolved Hide resolved
@kmadisa
SAR-393 Added a check to log when necessary
294e402 
Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
@kmadisa
Copy link
Contributor Author

kmadisa commented Jun 3, 2022

Merging this PR as the Jenkins' build passed.
Screenshot from 2022-06-03 15-22-54

@kmadisa kmadisa merged commit 75673d7 into master Jun 3, 2022
@kmadisa kmadisa deleted the kmadisa/SAR-393/Reduce-logs-spewed-by-device-servers branch June 3, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltwum1 samueltwum1 samueltwum1 approved these changes

@SKAJohanVenter SKAJohanVenter SKAJohanVenter approved these changes

Assignees

@kmadisa kmadisa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmadisa @samueltwum1 @SKAJohanVenter